Skip to content

fix: better t_Co=0 detection#204

Merged
habamax merged 2 commits into
masterfrom
fix/tcozero
Aug 8, 2022
Merged

fix: better t_Co=0 detection#204
habamax merged 2 commits into
masterfrom
fix/tcozero

Conversation

@habamax
Copy link
Copy Markdown
Collaborator

@habamax habamax commented Aug 7, 2022

@neutaaaaan pls check

Should close #202

@habamax
Copy link
Copy Markdown
Collaborator Author

habamax commented Aug 7, 2022

I have checked with :terminal in Gvim, works ok, set t_Co=0 also works in fedora36 and wsl/fedora.

@neutaaaaan
Copy link
Copy Markdown
Collaborator

I can't find a way to break it.
I'd merge, but seeing that lifepillar thinks it's inherently vim's fault, I'm going to let this linger a moment.

@lifepillar
Copy link
Copy Markdown
Contributor

lifepillar commented Aug 8, 2022

Even if it's recognized as a Vim bug, it's probably a good idea to make the color schemes robust against this issue. Before merging, can you check whether the t_Co test could be simplified, as I explained in the comment to the Colortemplate's pull request?

@habamax
Copy link
Copy Markdown
Collaborator Author

habamax commented Aug 8, 2022

I will update colorschemes here first and if it would be robust -- will update PR against colortemplate

@habamax
Copy link
Copy Markdown
Collaborator Author

habamax commented Aug 8, 2022

@neutaaaaan pls check

@neutaaaaan
Copy link
Copy Markdown
Collaborator

Looks good to me, can't break this either.

@habamax
Copy link
Copy Markdown
Collaborator Author

habamax commented Aug 8, 2022

colortemplate PR is updated

@habamax habamax merged commit a5acf22 into master Aug 8, 2022
@habamax habamax deleted the fix/tcozero branch August 25, 2022 09:01
xaverh pushed a commit to xaverh/qillqaq9 that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set t_Co=0 ignores _tcozero

3 participants