Changing colorscheme doesn't change g:terminal_ansi_colors in opened terminal buffer

[craigmac]

Sorry for another sort-of-odd one and the mind dump, but try this out:

vim --clean
:set termguicolors
" open some random file, vimrc will do...
:colorscheme blue
:term

Here we are with g:terminal_ansi_colors echo'd and a 256 color test script ran in the terminal buffer:

Now escape to terminal normal mode with <C-\><C-n> and run:

:colorscheme habamax

Echoing g:terminal_ansi_colors we can see that they were set correctly to the new habamax defined colors, but the terminal buffers palette is not actually updated. It stays this way even when I tried re-running the 256 demo script and hiding the terminal buffer and reopening it. I expected switching colorscheme would trigger re-coloring of terminal buffers, but it doesn't seem to work this way, it seems only the terminal buffer background colour is changed. I would think this is better handled in vim/vim, but maybe there's something that could be done on colorscheme side? Just thinking out loud, seems like it could be a can of worms (as usual heh).

This is on latest Alacritty release (no tmux running), macOS, and Vim 9.0.1476 huge without GUI, compiled from source.

[neutaaaaan]

I've noticed the same thing before, but I don't think we can do anything about it on the colourscheme side, and it's kind of an edge case anyway.

The built-in terminal has different behaviours depending on whether you're using the 256c version, or the 24bit one as well, which I believe boil down to the library used under the hood. It might interfere with the way vim handles colourschemes.

I think it's worth filing an issue in the main repository, but I wouldn't expect it to change any time soon either.

[brammool]

I don't think that one can expect that changing g:terminal_ansi_colors will have an immediate effect. It is used when opening a new terminal, not for an existing terminal. Although you can probably refresh it by toggling 'termguicolors'.
I am not sure if changing the value of a global variable should have a side effect. The term_setansicolors() function was meant for that.

[brammool]

Sorry for another sort-of-odd one and the mind dump, but try this out: ``` vim --clean :set termguicolors " open some random file, vimrc will do... :colorscheme blue :term ``` Here we are with `g:terminal_ansi_colors` echo'd and a 256 color test script ran in the terminal buffer: <img width="2032" alt="Screenshot 2023-05-04 at 12 47 24 PM" src="https://user-images.githubusercontent.com/7416158/236271253-add552b1-9595-4996-89ed-73fbd9c1886c.png"> Now escape to terminal normal mode with `<C-\><C-n>` and run: ``` :colorscheme habamax ``` <img width="2032" alt="Screenshot 2023-05-04 at 12 49 21 PM" src="https://user-images.githubusercontent.com/7416158/236271690-820c28db-e5ff-4319-945d-3d0e5d116264.png"> Echoing `g:terminal_ansi_colors` we can see that they were set correctly to the new habamax defined colors, but the terminal buffers palette is not actually updated. It stays this way even when I tried re-running the 256 demo script and hiding the terminal buffer and reopening it. I expected switching colorscheme would trigger re-coloring of terminal buffers, but it doesn't seem to work this way, it seems only the terminal buffer background colour is changed. I would think this is better handled in vim/vim, but maybe there's something that could be done on colorscheme side? Just thinking out loud, seems like it could be a can of worms (as usual heh).

The colorscheme affects the things displayed in Vim, especially syntax highlighting and other UI elements. What happens in a terminal depends on what is running in there. E.g. if you would run Vim in the terminal window you can set a colorscheme in that one and expect it to not be changed by the colorscheme in the top level Vim, that runs the terminal window. Except for the normal foreground/background colors, since these are set by the terminal (even when not using any colorscheme).

…

-- Often you're less important than your furniture. If you think about it, you can get fired but your furniture stays behind, gainfully employed at the company that didn't need _you_ anymore. (Scott Adams - The Dilbert principle) /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[chrisbra]

closing then.