Skip to content

Add ftplugin files for Jinja#20778

Closed
Freed-Wu wants to merge 1 commit into
vim:masterfrom
Freed-Wu:jinja
Closed

Add ftplugin files for Jinja#20778
Freed-Wu wants to merge 1 commit into
vim:masterfrom
Freed-Wu:jinja

Conversation

@Freed-Wu

Copy link
Copy Markdown
Contributor

Comes from #15689 (comment)

@chrisbra

Copy link
Copy Markdown
Member

thanks, but why is the maintainer @gpanders but the repo under @HiPhish ?

Also, I'd prefer if the upstream maintainer sends this over so we are in agreement here.

@Freed-Wu

Copy link
Copy Markdown
Contributor Author

why is the maintainer

Fixed.

if the upstream maintainer sends this

I ask it in HiPhish/jinja.vim#9

so we are in agreement here.

In fact, https://github.com/HiPhish/jinja.vim/blob/master/ftplugin/jinja.vim only has one line, so I think it is not a large problem.

@chrisbra

Copy link
Copy Markdown
Member

@HiPhish can you please confirm here?

@HiPhish

HiPhish commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Hi, what exactly is the issue here? It's one line of trivial Vim script, I highly doubt that I could copyright that. If you want my permission to copy & paste it, then yes sure, do whatever you want with it.

Is there something I can do for you in order to avoid legal ambiguity in the future? Maybe put an SPDX license identifier at the top? Use the Unlicense to effectively place the file in the public domain?

@chrisbra

Copy link
Copy Markdown
Member

Thanks. No that won't be required. We just prefer to have an explicit consensus before we include a change someone authored. (I believe that was Brams preference and I also prefer this for the reason to be explicit).

Although the license would allow it, I think it is good style to get explicit acknowledgement from the authors.

I include it then.

@chrisbra chrisbra closed this in ac1bb93 Jul 18, 2026
zeertzjq added a commit to neovim/neovim that referenced this pull request Jul 19, 2026
closes: vim/vim#20778

vim/vim@ac1bb93

Co-authored-by: Wu, Zhenyu <wuzhenyu@ustc.edu>
Co-Authored-by: Alejandro Sanchez <hiphish@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants