Allow the \%#= atom only at the start of the pattern#10439
Closed
chrisbra wants to merge 1 commit intovim:masterfrom
Closed
Allow the \%#= atom only at the start of the pattern#10439chrisbra wants to merge 1 commit intovim:masterfrom
chrisbra wants to merge 1 commit intovim:masterfrom
Conversation
chrisbra
changed the title
chrisbra
force-pushed
the
two_engines_pattern
branch
2 times, most recently
from
774bb4d to
c52cb78
Compare
chrisbra
force-pushed
the
two_engines_pattern
branch
from
c52cb78 to
6865cbc
Compare
Codecov Report
@@ Coverage Diff @@
## master #10439 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 158 158
Lines 184714 184729 +15
Branches 41765 41767 +2
=======================================
+ Hits 150789 150803 +14
+ Misses 21436 21431 -5
- Partials 12489 12495 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Nov 5, 2022
…tart Problem: No error if engine selection atom is not at the start. Solution: Give an error. (Christian Brabandt, closes vim/vim#10439) vim/vim@360da40 Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Nov 5, 2022
…tart Problem: No error if engine selection atom is not at the start. Solution: Give an error. (Christian Brabandt, closes vim/vim#10439) vim/vim@360da40 Co-authored-by: Christian Brabandt <cb@256bit.org>
yesean
pushed a commit
to yesean/neovim
that referenced
this pull request
Mar 25, 2023
…tart Problem: No error if engine selection atom is not at the start. Solution: Give an error. (Christian Brabandt, closes vim/vim#10439) vim/vim@360da40 Co-authored-by: Christian Brabandt <cb@256bit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the pattern %#= is allowed everywhere, but only if it is at the start of the pattern, it will actually select the correct regexp engine.
However, Vim will happily accept a pattern like 'foo%#=2bar' but will interpret
\%#as the current cursor position. So make the regexp a bit more strict and output an error, if the special atom\%#=is found anywhere but at the start of the pattern.