Skip to content

runtime:compiler:feat: unify node-based makeprgs #18798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Konfekt wants to merge 7 commits into
base: master
Choose a base branch
from
Open

runtime:compiler:feat: unify node-based makeprgs #18798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91428c1
runtime:compiler:feat: unify node-based makeprgs
Konfekt Nov 16, 2025
efe6e30
feat: add per-compiler makeprg checks and prefer them over node_makeprg
Konfekt Nov 22, 2025
14013f1
refactor: shorten makeprg setup with ternary in compilers
Konfekt Nov 22, 2025
2f9c57c
use javascript_node_makeprg instead of node_makeprg as suggested by @…
Konfekt Nov 22, 2025
4f882b7
fix: mixed indent
Konfekt Nov 22, 2025
de4aa62
remove @djmoch as maintainer
Konfekt Nov 22, 2025
a22df55
use tabs for erroformat as kindly pointed out by @chrisbra
Konfekt Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions runtime/compiler/biome.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,21 @@
" Compiler: Biome (= linter for JavaScript, TypeScript, JSX, TSX, JSON,
" JSONC, HTML, Vue, Svelte, Astro, CSS, GraphQL and GritQL files)
" Maintainer: @Konfekt
" Last Change: 2025 Nov 12
" Last Change: 2025 Nov 16
if exists("current_compiler") | finish | endif
let current_compiler = "biome"

let s:cpo_save = &cpo
set cpo&vim

exe 'CompilerSet makeprg=' .. escape('biome check --linter-enabled=true --formatter-enabled=false --assist-enabled=false --reporter=github '
\ .. get(b:, 'biome_makeprg_params', get(g:, 'biome_makeprg_params', '')), ' \|"')
" CompilerSet makeprg=biome
" CompilerSet makeprg=npx\ biome
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'biome_makeprg', get(g:, 'biome_makeprg', ''))) ?
\ get(b:, 'biome_makeprg', get(g:, 'biome_makeprg', '')) :
Copy link
Member

@chrisbra chrisbra Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biome is quite new, let's rather keep it simple and jut use the javascript_node_makeprg instead and get rid of the whole biome_makeprg option instead. This simplifies this whole thing here.

\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' @biomejs/biome'))
\ .. ' check --linter-enabled=true --formatter-enabled=false --assist-enabled=false --reporter=github '
\ .. get(b:, 'biome_makeprg_params', get(g:, 'biome_makeprg_params', '')), ' \|"')

CompilerSet errorformat=::%trror%.%#file=%f\\,line=%l\\,%.%#col=%c\\,%.%#::%m
CompilerSet errorformat+=::%tarning%.%#file=%f\\,line=%l\\,%.%#col=%c\\,%.%#::%m
Expand Down
20 changes: 15 additions & 5 deletions runtime/compiler/csslint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
" Vim compiler file
" Compiler: csslint for CSS
" Maintainer: Daniel Moch <daniel@danielmoch.com>
" Last Change: 2016 May 21
" 2024 Apr 03 by The Vim Project (removed :CompilerSet definition)
" Compiler: csslint for CSS
" Previous Maintainer: Daniel Moch <daniel@danielmoch.com>
" Last Change: 2016 May 21
" 2024 Apr 03 by The Vim Project (removed :CompilerSet
" definition)
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
endif
let current_compiler = "csslint"

CompilerSet makeprg=csslint\ --format=compact
" CompilerSet makeprg=csslint
" CompilerSet makeprg=npx\ csslint
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'csslint_makeprg', get(g:, 'csslint_makeprg', ''))) ?
\ get(b:, 'csslint_makeprg', get(g:, 'csslint_makeprg', '')) :
Copy link
Member

@chrisbra chrisbra Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, let's not introduce another block of settings but stick to javascript_node_makeprg

\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' csslint'))
\ .. ' --format=compact ' ..
\ get(b:, 'csslint_makeprg_params', get(g:, 'csslint_makeprg_params', '')), ' \|"')

CompilerSet errorformat=%-G,%-G%f:\ lint\ free!,%f:\ line\ %l\\,\ col\ %c\\,\ %trror\ -\ %m,%f:\ line\ %l\\,\ col\ %c\\,\ %tarning\ -\ %m,%f:\ line\ %l\\,\ col\ %c\\,\ %m
10 changes: 9 additions & 1 deletion runtime/compiler/eslint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,19 @@
" Compiler: ESLint for JavaScript
" Maintainer: Romain Lafourcade <romainlafourcade@gmail.com>
" Last Change: 2024 Nov 30
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
endif
let current_compiler = "eslint"

CompilerSet makeprg=npx\ eslint\ --format\ stylish
" CompilerSet makeprg=eslint
" CompilerSet makeprg=npx\ eslint
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'eslint_makeprg', get(g:, 'eslint_makeprg', ''))) ?
\ get(b:, 'eslint_makeprg', get(g:, 'eslint_makeprg', '')) :
Copy link
Member

@chrisbra chrisbra Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar here please

\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' eslint'))
\ .. ' --format stylish ' ..
\ get(b:, 'eslint_makeprg_params', get(g:, 'eslint_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%-P%f,\%\\s%#%l:%c\ %#\ %trror\ \ %m,\%\\s%#%l:%c\ %#\ %tarning\ \ %m,\%-Q,\%-G%.%#,
16 changes: 12 additions & 4 deletions runtime/compiler/jest.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: Jest
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: Jest
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Last Change: 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -13,7 +14,14 @@ set cpo&vim

" CompilerSet makeprg=npx\ --no-install\ jest\ --no-colors

CompilerSet makeprg=jest\ --no-colors
" CompilerSet makeprg=jest
" CompilerSet makeprg=npx\ jest
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'jest_makeprg', get(g:, 'jest_makeprg', ''))) ?
\ get(b:, 'jest_makeprg', get(g:, 'jest_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jest'))
\ .. ' --no-colors ' ..
\ get(b:, 'jest_makeprg_params', get(g:, 'jest_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%-A\ \ ●\ Console,
\%E\ \ ●\ %m,
\%Z\ %\\{4}%.%#Error:\ %f:\ %m\ (%l:%c):%\\=,
Expand Down
18 changes: 13 additions & 5 deletions runtime/compiler/jshint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: JSHint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: JSHint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Last Change: 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -13,9 +14,16 @@ set cpo&vim

" CompilerSet makeprg=npx\ jshint\ --verbose

CompilerSet makeprg=jshint\ --verbose
" CompilerSet makeprg=jshint
" CompilerSet makeprg=npx\ jshint
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'jshint_makeprg', get(g:, 'jshint_makeprg', ''))) ?
\ get(b:, 'jshint_makeprg', get(g:, 'jshint_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jshint'))
\ .. ' --verbose ' ..
\ get(b:, 'jshint_makeprg_params', get(g:, 'jshint_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ %m\ (%t%n),
\%-G%.%#
\%-G%.%#

let &cpo = s:cpo_save
unlet s:cpo_save
18 changes: 13 additions & 5 deletions runtime/compiler/jsonlint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: JSON Lint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: JSON Lint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Last Change: 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -13,9 +14,16 @@ set cpo&vim

" CompilerSet makeprg=npx\ jsonlint\ --compact\ --quiet

CompilerSet makeprg=jsonlint\ --compact\ --quiet
" CompilerSet makeprg=jsonlint
" CompilerSet makeprg=npx\ jsonlint
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'jsonlint_makeprg', get(g:, 'jsonlint_makeprg', ''))) ?
\ get(b:, 'jsonlint_makeprg', get(g:, 'jsonlint_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jsonlint'))
\ .. ' --compact --quiet ' ..
\ get(b:, 'jsonlint_makeprg_params', get(g:, 'jsonlint_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ found:\ %m,
\%-G%.%#
\%-G%.%#

let &cpo = s:cpo_save
unlet s:cpo_save
10 changes: 5 additions & 5 deletions runtime/compiler/pylint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
" Vim compiler file
" Compiler: Pylint for Python
" Maintainer: Daniel Moch <daniel@danielmoch.com>
" Last Change: 2024 Nov 07 by The Vim Project (added params variable)
" 2024 Nov 19 by the Vim Project (properly escape makeprg setting)
" 2025 Nov 06 by the Vim Project (do not set buffer-local makeprg)
" Compiler: Pylint for Python
" Previous Maintainer: Daniel Moch <daniel@danielmoch.com>
" Last Change: 2024 Nov 07 by The Vim Project (added params variable)
" 2024 Nov 19 by the Vim Project (properly escape makeprg setting)
" 2025 Nov 06 by the Vim Project (do not set buffer-local makeprg)

if exists("current_compiler") | finish | endif
let current_compiler = "pylint"
Expand Down
18 changes: 13 additions & 5 deletions runtime/compiler/sass.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
" Vim compiler file
" Compiler: Sass
" Maintainer: Tim Pope <vimNOSPAM@tpope.org>
" Last Change: 2016 Aug 29
" 2024 Apr 03 by The Vim Project (removed :CompilerSet definition)
" Compiler: Sass
" Maintainer: Tim Pope <vimNOSPAM@tpope.org>
" Last Change: 2016 Aug 29
" 2024 Apr 03 by The Vim Project (removed :CompilerSet definition)
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -12,7 +13,14 @@ let current_compiler = "sass"
let s:cpo_save = &cpo
set cpo-=C

CompilerSet makeprg=sass
" CompilerSet makeprg=sass
" CompilerSet makeprg=npx\ sass
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'sass_makeprg', get(g:, 'sass_makeprg', ''))) ?
\ get(b:, 'sass_makeprg', get(g:, 'sass_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' sass'))
\ .. ' ' ..
\ get(b:, 'sass_makeprg_params', get(g:, 'sass_makeprg_params', '')), ' \|"')

CompilerSet errorformat=
\%f:%l:%m\ (Sass::Syntax%trror),
Expand Down
12 changes: 10 additions & 2 deletions runtime/compiler/standard.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,20 @@
" Compiler: Standard for JavaScript
" Maintainer: Romain Lafourcade <romainlafourcade@gmail.com>
" Last Change: 2020 August 20
" 2024 Apr 03 by The Vim Project (removed :CompilerSet definition)
" 2024 Apr 03 by The Vim Project (removed :CompilerSet definition)
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
endif
let current_compiler = "standard"

CompilerSet makeprg=npx\ standard
" CompilerSet makeprg=standard
" CompilerSet makeprg=npx\ standard
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'standard_makeprg', get(g:, 'standard_makeprg', ''))) ?
\ get(b:, 'standard_makeprg', get(g:, 'standard_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' standard'))
\ .. ' ' ..
\ get(b:, 'standard_makeprg_params', get(g:, 'standard_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%f:%l:%c:\ %m,%-G%.%#
20 changes: 14 additions & 6 deletions runtime/compiler/stylelint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: Stylelint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: Stylelint
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -13,10 +14,17 @@ set cpo&vim

" CompilerSet makeprg=npx\ stylelint\ --formatter\ compact

CompilerSet makeprg=stylelint\ --formatter\ compact
" CompilerSet makeprg=stylelint
" CompilerSet makeprg=npx\ stylelint
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'stylelint_makeprg', get(g:, 'stylelint_makeprg', ''))) ?
\ get(b:, 'stylelint_makeprg', get(g:, 'stylelint_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' stylelint'))
\ .. ' --formatter compact ' ..
\ get(b:, 'stylelint_makeprg_params', get(g:, 'stylelint_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ %trror\ -\ %m,
\%f:\ line\ %l\\,\ col\ %c\\,\ %tarning\ -\ %m,
\%-G%.%#
\%f:\ line\ %l\\,\ col\ %c\\,\ %tarning\ -\ %m,
\%-G%.%#

let &cpo = s:cpo_save
unlet s:cpo_save
15 changes: 11 additions & 4 deletions runtime/compiler/svelte-check.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
" Vim compiler file
" Compiler: svelte-check
" Maintainer: @Konfekt
" Last Change: 2025 Feb 27
" Compiler: svelte-check
" Maintainer: @Konfekt
" Last Change: 2025 Nov 16

if exists("current_compiler") | finish | endif
let current_compiler = "svelte-check"

CompilerSet makeprg=npx\ svelte-check\ --output\ machine
" CompilerSet makeprg=svelte-check
" CompilerSet makeprg=npx\ svelte-check
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'svelte_check_makeprg', get(g:, 'svelte_check_makeprg', ''))) ?
\ get(b:, 'svelte_check_makeprg', get(g:, 'svelte_check_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' svelte-check'))
\ .. ' --output machine ' ..
\ get(b:, 'svelte_check_makeprg_params', get(g:, 'svelte_check_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%*\\d\ %t%*\\a\ \"%f\"\ %l:%c\ \"%m\",
CompilerSet errorformat+=%-G%*\\d\ START\ %.%#,
CompilerSet errorformat+=%-G%*\\d\ COMPLETED\ %.%#,
Expand Down
16 changes: 11 additions & 5 deletions runtime/compiler/ts-node.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: TypeScript Runner
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: TypeScript Runner
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -11,9 +12,14 @@ let current_compiler = "node"
let s:cpo_save = &cpo
set cpo&vim

" CompilerSet makeprg=ts-node
" CompilerSet makeprg=npx\ ts-node

CompilerSet makeprg=ts-node
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'ts_node_makeprg', get(g:, 'ts_node_makeprg', ''))) ?
\ get(b:, 'ts_node_makeprg', get(g:, 'ts_node_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' ts-node'))
\ .. ' ' ..
\ get(b:, 'ts_node_makeprg_params', get(g:, 'ts_node_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%f\ %#(%l\\,%c):\ %trror\ TS%n:\ %m,
\%E%f:%l,
\%+Z%\\w%\\+Error:\ %.%#,
Expand Down
17 changes: 12 additions & 5 deletions runtime/compiler/tsc.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
" Vim compiler file
" Compiler: TypeScript Compiler
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" 2025 Mar 11 by The Vim Project (add comment for Dispatch, add tsc_makeprg variable)
" Compiler: TypeScript Compiler
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" 2025 Mar 11 by The Vim Project (add comment for Dispatch, add tsc_makeprg variable)
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -14,7 +15,13 @@ set cpo&vim

" CompilerSet makeprg=tsc
" CompilerSet makeprg=npx\ tsc
execute $'CompilerSet makeprg={escape(get(b:, 'tsc_makeprg', get(g:, 'tsc_makeprg', 'tsc')), ' \|"')}'
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'tsc_makeprg', get(g:, 'tsc_makeprg', ''))) ?
\ get(b:, 'tsc_makeprg', get(g:, 'tsc_makeprg', '')) :
\ get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' tsc')
\ .. ' ' ..
\ get(b:, 'tsc_makeprg_params', get(g:, 'tsc_makeprg_params', '')), ' \|"')

CompilerSet errorformat=%f\ %#(%l\\,%c):\ %trror\ TS%n:\ %m,
\%trror\ TS%n:\ %m,
\%-G%.%#
Expand Down
16 changes: 12 additions & 4 deletions runtime/compiler/typedoc.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
" Vim compiler file
" Compiler: TypeDoc
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" Compiler: TypeDoc
" Maintainer: Doug Kearns <dougkearns@gmail.com>
" Last Change: 2024 Apr 03
" 2025 Nov 22 by The Vim Project (default to npx)

if exists("current_compiler")
finish
Expand All @@ -13,7 +14,14 @@ set cpo&vim

" CompilerSet makeprg=npx\ typedoc

CompilerSet makeprg=typedoc
" CompilerSet makeprg=typedoc
" CompilerSet makeprg=npx\ typedoc
exe 'CompilerSet makeprg=' .. escape(
\ (!empty(get(b:, 'typedoc_makeprg', get(g:, 'typedoc_makeprg', ''))) ?
\ get(b:, 'typedoc_makeprg', get(g:, 'typedoc_makeprg', '')) :
\ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' typedoc'))
\ .. ' ' ..
\ get(b:, 'typedoc_makeprg_params', get(g:, 'typedoc_makeprg_params', '')), ' \|"')
CompilerSet errorformat=%EError:\ %f(%l),
\%WWarning:\ %f(%l),
\%+IDocumentation\ generated\ at\ %f,
Expand Down
Loading
Loading