Memory leak with :breakadd expr #18844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Memory leak with :breakadd expr. Solution: Free debug_oldval and debug_newval before assigning to them. It seems that :breakadd expr doesn't work as documented at all. This PR only fixes the memory leak. The tests are for the existing behavior.
zeertzjq
force-pushed
the
debugger-leak
branch
from
8473a9c to
93449e4
Compare
Member
|
Thanks, the memory leak is my fault I guess. I remember some wonky behavior when implementing the expr part of it. Seems like it is not much used really. |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Dec 1, 2025
Problem: Memory leak with :breakadd expr
Solution: Free debug_oldval and debug_newval before assigning to them.
Verify the existing (though confusing) :breakadd expr behavior
(zeertzjq).
It seems that :breakadd expr doesn't work as documented at all. This PR
only fixes the memory leak. The tests are for the existing behavior.
closes: vim/vim#18844
vim/vim@a474de6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Memory leak with :breakadd expr.
Solution: Free debug_oldval and debug_newval before assigning to them.
It seems that :breakadd expr doesn't work as documented at all. This PR
only fixes the memory leak. The tests are for the existing behavior.