-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add compiling with clang as default. #19043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bin/compile.sh
Outdated
| @@ -0,0 +1,11 @@ | |||
| #!/usr/bin/env fish | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't bash be a more common choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to sh.
src/Makefile
Outdated
| #instead of using the default from the "make" program. | ||
| #Use a line further down to change the value for CC. | ||
| CC= | ||
| CC=clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not backwards compatible, as not everyone will have the Clang toolchain installed in their environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Please look.
|
This is not needed and the provided shell script is trivial. When I am compiling locally, I typically modify the Makefile (as I often need to compile using different feature flags or test with different compilers) and this works just fine. However in your case, you can just use |
|
So what I wanted is: Anyway I am for scripts in
Seems not to work with |
Hello,
I just tried compiling
vimwithclang.It is not stright forward.
Thought it should work like this:
gh repo clone vim/vim cd ./vim/src/ CC=clang make sudo make installI added a script and modified
Makefile, but in the end would like a simplier solution to use a different compiler.