heap buffer overflow with long generic function name#19727
Closed
chrisbra wants to merge 1 commit intovim:masterfrom
Closed
heap buffer overflow with long generic function name#19727chrisbra wants to merge 1 commit intovim:masterfrom
chrisbra wants to merge 1 commit intovim:masterfrom
Conversation
Problem: Using a long generic function name may cause a heap buffer
overflow in common_function().
Solution: Allocate memory for the full name instead of using IObuff.
(Kaixuan Li)
Signed-off-by: Christian Brabandt <cb@256bit.org>
yegappan
reviewed
Mar 17, 2026
|
|
||
| " Test for long gerneric type name {{{1 | ||
| func Test_function_long_generic_name() | ||
| func TestFunc() |
Member
There was a problem hiding this comment.
Should this be def TestFunc()?
yegappan
reviewed
Mar 17, 2026
| endfunc | ||
|
|
||
| " Test for long gerneric type name {{{1 | ||
| func Test_function_long_generic_name() |
Member
There was a problem hiding this comment.
Both of these functions should be def functions?
Member
Author
There was a problem hiding this comment.
shouldn't really matter, no?
Member
There was a problem hiding this comment.
To detect this buffer overflow condition, func or def definition shouldn't really matter.
yegappan
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Using a long generic function name may cause a heap buffer
overflow in common_function().
Solution: Allocate memory for the full name instead of using IObuff.
(Kaixuan Li)