fix: redraw status lines after closing or hiding a popup window#19830
Closed
mattn wants to merge 2 commits intovim:masterfrom
Closed
fix: redraw status lines after closing or hiding a popup window#19830mattn wants to merge 2 commits intovim:masterfrom
mattn wants to merge 2 commits intovim:masterfrom
Conversation
When a popup window overlapping a status line is closed or hidden, the status line was not redrawn, leaving ghost artifacts from the popup. popup_free() and popup_hide() call redraw_all_later(UPD_NOT_VALID) which marks window contents for redraw but does not set w_redr_status. The diff-based path in may_update_popup_mask() that normally sets w_redr_status is skipped when redrawing_all_win is TRUE. Add status_redraw_all() calls to ensure status lines are properly redrawn.
Test that closing a popup window overlapping a status line properly redraws the status line without leaving ghost artifacts.
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a popup window overlapping a status line is closed or hidden, the status line was not redrawn, leaving ghost artifacts from the popup.
popup_free() and popup_hide() call redraw_all_later(UPD_NOT_VALID) which marks window contents for redraw but does not set w_redr_status. The diff-based path in may_update_popup_mask() that normally sets w_redr_status is skipped when redrawing_all_win is TRUE. Add status_redraw_all() calls to ensure status lines are properly redrawn.