tests(commondumps): Use character counts when marking columns#20237
Closed
zzzyxwvut wants to merge 1 commit into
Closed
tests(commondumps): Use character counts when marking columns#20237zzzyxwvut wants to merge 1 commit into
zzzyxwvut wants to merge 1 commit into
Conversation
Continue using "strwidth" when calculating the position of a column of interest, and start using "setcharpos" when marking a line of interest so that paired-up marks remain aligned columnwise across all three parts generated by "term_dumpdiff", especially when multibyte characters are written in the line before the marked column. Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com>
Contributor
Author
|
We can see the result of counting column positions in bytes cd runtime/syntax
git switch --detach v9.2.0498
git revert --no-edit -Xours f7e239bd0
make clean sh_functions_bash.sh test
../../src/vim --clean -S testdir/viewdumps.vim
# :normal `a
# :normal ``
# :normal `` |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue using
strwidthwhen calculating the position ofa column of interest, and start using
setcharposwhenmarking a line of interest so that paired-up marks remain
aligned columnwise across all three parts generated by
term_dumpdiff, especially when multibyte characters arewritten in the line before the marked column.