Fix issues with specfile plugin and stop adding variable names to changelog message #3844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix regular expression for getting values of variables defined by global or define keywords fix typo in return of unresolved variable fix check for nonfound value if match was not found by search function then 0 is returned (see :help search for further info)
variables which definition has not been found are now not added to changelog message
Codecov Report
@@ Coverage Diff @@
## master #3844 +/- ##
==========================================
+ Coverage 78.64% 78.64% +<.01%
==========================================
Files 103 103
Lines 141890 141890
==========================================
+ Hits 111585 111588 +3
+ Misses 30305 30302 -3
Continue to review full report at Codecov.
|
|
Have you contact the maintainer? |
|
No. I'm sorry this is my first contribution to vim. I will contact him right away. |
Sarayutnang2099
approved these changes
Feb 10, 2019
|
Closing, since this is not something to include. If the maintainer does not respond consider taking over maintenance. Then re-open the pull request (or create a new one). |
|
LGTM |
|
I'll include it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3843
resolves #3842
Please see issues and commit messages for more info.