Conversation
Enable Code scanning for security vulnerabilities. Github just announced to allow automatic code scanning using Code-QL here: https://github.blog/2020-09-30-code-scanning-is-now-available/ So let's just set this up and see if this works (or if it causes too many problems and false positives we can disable it again).
Codecov Report
@@ Coverage Diff @@
## master #7057 +/- ##
==========================================
+ Coverage 88.46% 88.64% +0.18%
==========================================
Files 148 148
Lines 158938 161760 +2822
==========================================
+ Hits 140605 143395 +2790
- Misses 18333 18365 +32
Continue to review full report at Codecov.
|
Contributor
|
Looks like you need to remove "javascript". |
remove javascript
Contributor
|
Can you re-trigger CI? Patch 8.2.1783 should fix the failures. I wonder if I could trigger this somehow... |
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Oct 3, 2020
Problem: Crash with 'incsearch' and very long line. Solution: Check whether regprog becomes NULL. (closes vim/vim#7063) vim/vim@795aaa1 N/A patches for version.c: vim-patch:8.2.1784: commits are not scanned for security problems Problem: commits are not scanned for security problems Solution: Enable Github code scanning. (Christian Brabandt, closes vim/vim#7057) vim/vim@fa79be6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Code scanning for security vulnerabilities.
Github just announced to allow automatic code scanning using Code-QL here: https://github.blog/2020-09-30-code-scanning-is-now-available/
So let's just set this up and see if this works (or if it causes too many problems and false positives we can disable it again).