Allow changing subject claim #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimalloc
reviewed
Jul 12, 2017
flask_jwt_extended/tokens.py
Outdated
|
|
||
|
|
||
| def decode_jwt(encoded_token, secret, algorithm, csrf): | ||
| def decode_jwt(encoded_token, secret, algorithm, csrf, identity): |
Owner
There was a problem hiding this comment.
Could we add this to the encode_refresh_token and encode_access_token too? I think the identity kwarg is already in use, so we could use something like identity_claim or something instead? In fact, maybe we should change this to identity_claim as well?
We will need to update the calls to encode_access_token and encode_refresh_token as well. I think those are only used in the jwt_manager.py.
vimalloc
reviewed
Jul 12, 2017
| such as ``RS*`` or ``ES*``. PEM format expected. | ||
| ``JWT_IDENTITY_CLAIM`` Claim in the tokens that is used on decoding as source of identity. | ||
| For interoperativity, the JWT RFC recommends using ``'sub'``. | ||
| Defaults to ``'identity'``. |
Owner
There was a problem hiding this comment.
In conjunction with the comment below, lets remove the decoding from this, as it will be both encoding and
decoding.
psafont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes which claim to validate and retrieve as 'identity', as a client.
Allows user to configure which is the claim through app.config.
Related to issue #65