Fix for #74 do not fail with empty request to /auth #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so using request.get_json()
vimalloc
reviewed
Aug 1, 2017
examples/simple.py
Outdated
|
|
||
| if request.is_json: | ||
| params = request.get_json() | ||
| if 'username' in params.keys() and 'password' in params.keys(): |
Owner
There was a problem hiding this comment.
Can you change this to not use .keys()? Doing 'username' in params is more efficient (at least with python2), as .keys() makes a copy of the keys into a list, which you then have to iterate through (O(n) instead of O(1))
| ret = {'access_token': create_access_token(identity=params['username'])} | ||
| return jsonify(ret), 200 | ||
| else: | ||
| return jsonify({"msg": "Missing auth"}), 401 |
Owner
There was a problem hiding this comment.
Just to avoid a bunch of nested if's, can you lift this to the top? Something like
if not request.is_json:
return jsonify({"msg": "Missing auth"}), 401
# rest of the code, but not nested in an if block any more
Owner
|
Thanks for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.