Populate tooltips with summary data by david-mears-2 · Pull Request #30 · vimc/vaxviz

david-mears-2 · 2026-01-16T19:21:01Z

(failed to use the branch name to tag https://mrc-ide.myjetbrains.com/youtrack/issue/VIMC-9196/Populate-tooltip-content-with-data-from-summary-tables )

Changes

dataStore

First there were the changes to the dataStore, which originally just managed histogram data json files, but now does what we call 'summary table' data: that's the mean, median, and 95% CI for each set of ridgeline data.

I'm planning to reuse this same summary data for the ordering / ranking of plot rows, in a later PR.

Tooltips themselves

That was required to get the data to put in tooltips. The composable is responsible for creating a callback (at chart initialization time) which is invoked when the chart is hovered: returns HTML that gets slotted inside a skadi-chart element.

Open problems

An experimental branch visualizing the 95% CI intervals makes me worry that either the summary table data provided to us by VIMC is incorrect, OR I have incorrectly looked up the wrong summary table data in some way:

AI??

I got copilot to write some basic unit tests in another PR, which I reviewed (gave feedback on, finally submitted another human-written commit on top), and then merged into this branch.

…ilename'

…tips-with-summary-data

codecov · 2026-01-16T19:25:40Z

Codecov Report

❌ Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.67%. Comparing base (038a58a) to head (4cbd8e1).
⚠️ Report is 28 commits behind head on rename-enums.

Files with missing lines	Patch %	Lines
src/composables/usePlotTooltips.ts	96.87%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           rename-enums      #30      +/-   ##
================================================
+ Coverage         97.64%   97.67%   +0.03%     
================================================
  Files                18       18              
  Lines               382      430      +48     
  Branches             93      103      +10     
================================================
+ Hits                373      420      +47     
- Misses                9       10       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

…tips Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

…imension Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

Add unit tests for tooltip summary data and conditional dimension display

…y) array

EmmaLRussell

Tooltips look great - I like the colour blob to visually link with the histogram.

Check with Katy on this, but I would expect the number format in the tooltips to match the numbers on the axes - so 0.18 is fine for non-log but would expect it to be 1.8 × 10⁻¹ in log scale.

I think Katy suggested just including mean and 95% CI so not sure if median really needed.

Weird about the CI numbers not matching. Did the summary table data come from the same report version as the rest?

EmmaLRussell · 2026-01-20T10:32:10Z

src/composables/usePlotTooltips.ts

+    const summaryDataRow = summaryTableData.find(d => {
+      return Object.entries(dimensions).every(([axis, dim]) => {
+        return !dim || d[dim] === point.metadata?.[axis as Axis];
+      });
+    });


This is a little inscrutable, maybe worth a comment - is this about right?

Suggested change

const summaryDataRow = summaryTableData.find(d => {

return Object.entries(dimensions).every(([axis, dim]) => {

return !dim || d[dim] === point.metadata?.[axis as Axis];

});

});

// Find the summary table row whose values for the current UI row and band

// dimensions (and column, if set) match the values of the tooltip point

const summaryDataRow = summaryTableData.find(d => {

return Object.entries(dimensions).every(([axis, dim]) => {

return !dim || d[dim] === point.metadata?.[axis as Axis];

});

});

Added a comment

EmmaLRussell · 2026-01-20T10:42:18Z

src/composables/usePlotTooltips.ts

+
+    const includePositiveSign = ciLower && ciLower < 0;
+    const ciLowerMaybeWithSign = ciLower?.toFixed(2);
+    const ciUpperMaybeWithSign = `${includePositiveSign ? `${ciUpper && ciUpper > 0 ? '+' : ''}` : ''}${ciUpper?.toFixed(2)}`;


I think this would be more readable as two lines rather than having a bunch of logic in the string format. Don't really need to say ciUpper && ciUpper > 0 because null is not greater than 0 (assuming null is the only falsy option here?).

Suggested change

const ciUpperMaybeWithSign = `${includePositiveSign ? `${ciUpper && ciUpper > 0 ? '+' : ''}` : ''}${ciUpper?.toFixed(2)}`;

const ciUpperSign = (includePositiveSign && ciUpper > 0) ? '+' : '';

const ciUpperMaybeWithSign = `${ciUpperSign}${ciUpper?.toFixed(2)}`;

I can't do ciUpper && ciUpper > 0 because of typescript but I can do ciUpper! > 0.

EmmaLRussell · 2026-01-20T10:53:53Z

src/types.ts

-  [HistColumn.UPPER_BOUND]: number;
-  [HistColumn.COUNTS]: number;
 };
+export type HistDataRow = DataRow & Record<HistColumn, number>;


Why change the previous definition of HistDataRow? That seems clearer to me, and could use same approach to SummaryTableDataRow. It's a bit more verbose but also more readable. Also - this implies that the HistColumn and SummaryTableDataRow may not contain all the expected data value columns - is that actually the case?

I wanted to put all the columns shared between both types of data file into the DataRow type. Maybe it was premature optimization!

The optional columns:

activity type may not be present depending on the file

same for country and subregion

the location column is added by the data store as a merger of country/subregion/global (so it doesn't exist until processed by the store)

I'm removing the 'DataRow' type and just tolerating the slight duplication

EmmaLRussell · 2026-01-20T11:00:51Z

tests/unit/stores/dataStore.spec.ts

-        lower_bound: -2.434,
-        upper_bound: -2.422,
-      });
+      expect(dataStore.histogramData[0]).toEqual(expect.objectContaining({ disease: "Cholera" }));


Not sure why you've removed the full equality check here, but if you really do want to just check for disease value, I don't think objectContaining is really doing much here, could just have:

Suggested change

expect(dataStore.histogramData[0]).toEqual(expect.objectContaining({ disease: "Cholera" }));

expect(dataStore.histogramData[0]["disease"]).toEqual("Cholera");

Similarly for line 55

I'm not sure why I removed those checks, reinstating

david-mears-2 · 2026-01-21T12:21:37Z

Weird about the CI numbers not matching. Did the summary table data come from the same report version as the rest?

It still looks like this after updating all data to the latest packet. Katy's looking into it I think.

david-mears-2 · 2026-01-21T13:30:22Z

Check with Katy on this, but I would expect the number format in the tooltips to match the numbers on the axes - so 0.18 is fine for non-log but would expect it to be 1.8 × 10⁻¹ in log scale.

I have now implemented this.

I think Katy suggested just including mean and 95% CI so not sure if median really needed.

Removed median - better for space too.

david-mears-2 added 12 commits January 15, 2026 11:59

Add a summaryTablePaths getter to data store

a22f84b

DRY the filename constructor methods and fix naming from 'path' => 'f…

9d81a89

…ilename'

Rename existing internal methods on data store

2a5b96f

Update data store to load data from summary tables

596626c

DRY the data store

7d19845

Merge branch 'main' into populate-tooltips-with-summary-data

9d8bc1e

Merge branch 'update-skadi-chart-to-1.1.7-alpha.0' into populate-tool…

6413e19

…tips-with-summary-data

Merge branch 'rename-enums' into populate-tooltips-with-summary-data

2a310b9

Merge branch 'rename-enums' into populate-tooltips-with-summary-data

330795c

Bugfix for data store

e8afa2d

Populate tooltips with summary table data

84a7c3f

Fix unit test failures

2682e0c

Initial plan

6d4c022

Copilot AI mentioned this pull request Jan 16, 2026

Add unit tests for tooltip summary data and conditional dimension display #32

Merged

Copilot AI and others added 8 commits January 16, 2026 19:31

Initial exploration complete

5cfc536

Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

Add tests for new tooltip content (median, mean, 95% CI)

a654ed6

Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

Update tests to verify row dimension display and summary data in tool…

7b8abd3

…tips Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

Add assertions to verify row dimension not shown when same as color d…

05db003

…imension Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>

Update unit tests

2b95c6a

Merge pull request #32 from vimc/copilot/update-use-plot-tooltips-tests

c72cf02

Add unit tests for tooltip summary data and conditional dimension display

Comment

4f06a32

Merge branch 'rename-enums' into populate-tooltips-with-summary-data

be04d52

david-mears-2 marked this pull request as ready for review January 19, 2026 15:51

Fix refernce to array that should check length not existence of (empt…

1a65432

…y) array

david-mears-2 requested a review from EmmaLRussell January 19, 2026 16:33

EmmaLRussell reviewed Jan 20, 2026

View reviewed changes

david-mears-2 added 2 commits January 21, 2026 13:02

Implement review comments

2011864

Use scientific notation in tooltips when in log scale

f8272ab

Fix type

9f3e4fb

david-mears-2 requested a review from EmmaLRussell January 21, 2026 13:38

david-mears-2 added 2 commits January 21, 2026 15:00

Update comment

cc1061a

Extract a function in tooltips composable

4cbd8e1

EmmaLRussell approved these changes Jan 22, 2026

View reviewed changes

david-mears-2 merged commit b5c53bf into rename-enums Jan 22, 2026
4 checks passed

david-mears-2 deleted the populate-tooltips-with-summary-data branch January 22, 2026 12:08

	const ciUpperMaybeWithSign = `${includePositiveSign ? `${ciUpper && ciUpper > 0 ? '+' : ''}` : ''}${ciUpper?.toFixed(2)}`;
	const ciUpperSign = (includePositiveSign && ciUpper > 0) ? '+' : '';
	const ciUpperMaybeWithSign = `${ciUpperSign}${ciUpper?.toFixed(2)}`;

	expect(dataStore.histogramData[0]).toEqual(expect.objectContaining({ disease: "Cholera" }));
	expect(dataStore.histogramData[0]["disease"]).toEqual("Cholera");

Conversation

david-mears-2 commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

dataStore

Tooltips themselves

Open problems

AI??

Uh oh!

codecov bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

EmmaLRussell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-mears-2 Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

david-mears-2 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-mears-2 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-mears-2 commented Jan 16, 2026 •

edited

Loading

codecov bot commented Jan 16, 2026 •

edited

Loading

david-mears-2 Jan 21, 2026 •

edited

Loading

david-mears-2 commented Jan 21, 2026 •

edited

Loading

david-mears-2 commented Jan 21, 2026 •

edited

Loading