Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

tvOS-681: Add support for resume playback#120

Merged
jasonhawkins merged 8 commits intodevelopfrom
tvos-681-resume-playback-support
Mar 14, 2017
Merged

tvOS-681: Add support for resume playback#120
jasonhawkins merged 8 commits intodevelopfrom
tvos-681-resume-playback-support

Conversation

@jasonhawkins
Copy link
Copy Markdown
Contributor

Ticket

tvOS-681

Ticket Summary

Create a new model object for play progress, and add it as a property to VIMVideoPlayRepresentation.

Implementation Summary

  • Added PlayProgress model.
  • Added progress property to VIMVideoPlayRepresentation.

How to Test

n/a

@nicolelehrer nicolelehrer self-assigned this Mar 10, 2017

import Foundation

/// An object representing the amount of progress a video has been viewed.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"has been viewed." -> "for which a video has been played." ?

@cameo-github
Copy link
Copy Markdown

4 Warnings
⚠️ VimeoNetworking/Sources/Request+Notifications.swift#L54: result of call to ‘map’ is unused
notifications.map { (notification: VIMNotification) -> Void in
⚠️ VimeoNetworking/Sources/VimeoClient.swift#L328: cast from ‘Response<VIMNullResponse>’ to unrelated type ‘Response<ModelType>’ always fails
let response = Response(model: nullResponseObject, json: [:]) as! Response<ModelType>
⚠️ VimeoNetworking/Sources/Models/VIMVideoPreference.m#L41: incompatible pointer types assigning to ‘NSString * _Nullable’ from ‘VIMPrivacy * _Nullable’ [-Wincompatible-pointer-types]
privacy.view = self.privacy;
⚠️ VimeoNetworking/Sources/Models/VIMVODItem.m#L285: incompatible pointer types returning ‘VIMConnection * _Nullable’ from a function with result type ‘VIMVODConnection *’ [-Wincompatible-pointer-types]
return [self connectionWithName:VIMConnectionNameVideos];
1 Message
📖 Executed 22 tests, with 0 failures (0 unexpected) in 0.337 (0.348) seconds

See build details on CircleCI

Generated by 🚫 danger

@jasonhawkins jasonhawkins merged commit 70ab0ce into develop Mar 14, 2017
@jasonhawkins jasonhawkins deleted the tvos-681-resume-playback-support branch March 14, 2017 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants