Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

VIM-4712: Adding action sheet option to add to channel#139

Merged
ghking merged 2 commits intodevelopfrom
VIM-4712-adding-action-sheet-option
May 18, 2017
Merged

VIM-4712: Adding action sheet option to add to channel#139
ghking merged 2 commits intodevelopfrom
VIM-4712-adding-action-sheet-option

Conversation

@ghking
Copy link
Copy Markdown
Contributor

@ghking ghking commented May 11, 2017

@nicolelehrer
Copy link
Copy Markdown
Contributor

@ghking why are we removing hasCopyrightMatch? Could we do a quick PR description to account for these changes?

@ghking
Copy link
Copy Markdown
Contributor Author

ghking commented May 15, 2017

@nicolelehrer Copyright match was an old feature we removed a while ago, so this function just must have not been removed. We weren't using it anywhere so I just removed it while I was in there.

@cameo-github
Copy link
Copy Markdown

1 Warning
⚠️ VimeoNetworking/Sources/VimeoClient.swift#L326: cast from ‘Response<VIMNullResponse>’ to unrelated type ‘Response<ModelType>’ always fails
let response = Response(model: nullResponseObject, json: [:]) as! Response<ModelType>
1 Message
📖 Executed 22 tests, with 0 failures (0 unexpected) in 0.361 (0.378) seconds

See build details on CircleCI

Generated by 🚫 danger

@ghking ghking merged commit 5efffa2 into develop May 18, 2017
@ghking ghking deleted the VIM-4712-adding-action-sheet-option branch May 18, 2017 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants