Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

VIM-6220: Added the total cap exceeded status in the video object.#236

Merged
jenniferlim merged 2 commits intodevelopfrom
VIM-6220
Jun 14, 2018
Merged

VIM-6220: Added the total cap exceeded status in the video object.#236
jenniferlim merged 2 commits intodevelopfrom
VIM-6220

Conversation

@jenniferlim
Copy link
Copy Markdown
Contributor

@jenniferlim jenniferlim commented Jun 7, 2018

Ticket

VIM-6220

Pull Request Checklist

  • Resolved any merge conflicts
  • No build errors or warnings are introduced
  • New files are written in Swift
  • New classes contain license headers
  • New classes have Documentation
  • New public methods have Documentation

Issue Summary

A new video status was added to the 3.4.1 version of the API in order to differentiate between weekly storage cap quota_exceeded and the total storage cap total_cap_exceeded.

Implementation Summary

Added the new status total_cap_exceeded within the video object.

Reviewer Tips

How to Test

Checkout the iOS PR for testing.

@cameo-github
Copy link
Copy Markdown

8 Warnings
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L104: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/AFNetworking/AFURLSessionManager.m#L181: ‘setResumingHandler:’ is only available on iOS 9.0 or newer [-Wunguarded-availability]
[self.downloadProgress setResumingHandler:^{
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L76: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L97: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/AFNetworking/AFURLSessionManager.m#L163: ‘setResumingHandler:’ is only available on iOS 9.0 or newer [-Wunguarded-availability]
[self.uploadProgress setResumingHandler:^{
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L75: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L95: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L106: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
1 Message
📖 Executed 91 tests, with 0 failures (0 unexpected) in 0.840 (0.894) seconds

See build details on CircleCI

Generated by 🚫 danger

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #236 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    42.59%   42.67%   +0.07%     
===========================================
  Files           94       94              
  Lines         3221     3222       +1     
===========================================
+ Hits          1372     1375       +3     
+ Misses        1849     1847       -2
Impacted Files Coverage Δ
VimeoNetworking/Sources/Models/VIMVideo.m 57.83% <100%> (+0.22%) ⬆️
VimeoNetworking/Sources/ResponseCache.swift 73.71% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990d838...092e378. Read the comment docs.

@jenniferlim jenniferlim merged commit 1e9f02b into develop Jun 14, 2018
@jenniferlim jenniferlim deleted the VIM-6220 branch June 14, 2018 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants