Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

VIM-6338: MergeFeature/producer pro unlimited branch back into develop#248

Merged
jenniferlim merged 8 commits intodevelopfrom
feature/producer-proUnlimited
Jul 24, 2018
Merged

VIM-6338: MergeFeature/producer pro unlimited branch back into develop#248
jenniferlim merged 8 commits intodevelopfrom
feature/producer-proUnlimited

Conversation

@jenniferlim
Copy link
Copy Markdown
Contributor

Ticket

VIM-6338

Pull Request Checklist

  • Resolved any merge conflicts
  • No build errors or warnings are introduced
  • New files are written in Swift
  • New classes contain license headers
  • New classes have Documentation
  • New public methods have Documentation

Issue Summary

Merge feature branch back into develop/

Implementation Summary

N/A

Reviewer Tips

N/A

How to Test

N/A

@cameo-github
Copy link
Copy Markdown

8 Warnings
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L104: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/AFNetworking/AFURLSessionManager.m#L181: ‘setResumingHandler:’ is only available on iOS 9.0 or newer [-Wunguarded-availability]
[self.downloadProgress setResumingHandler:^{
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L76: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L97: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/AFNetworking/AFURLSessionManager.m#L163: ‘setResumingHandler:’ is only available on iOS 9.0 or newer [-Wunguarded-availability]
[self.uploadProgress setResumingHandler:^{
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L75: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L95: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L106: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
1 Message
📖 Executed 95 tests, with 0 failures (0 unexpected) in 0.890 (0.970) seconds

See build details on CircleCI

Generated by 🚫 danger

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #248 into develop will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
+ Coverage    42.68%   42.86%   +0.17%     
===========================================
  Files           94       94              
  Lines         3226     3236      +10     
===========================================
+ Hits          1377     1387      +10     
  Misses        1849     1849
Impacted Files Coverage Δ
VimeoNetworking/Sources/Models/VIMUserBadge.m 100% <100%> (ø) ⬆️
VimeoNetworking/Sources/Models/VIMUser.m 78.35% <100%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 597fd0c...37ddc12. Read the comment docs.

@jenniferlim jenniferlim merged commit 3e8317a into develop Jul 24, 2018
@jenniferlim jenniferlim deleted the feature/producer-proUnlimited branch July 24, 2018 18:28
@jenniferlim
Copy link
Copy Markdown
Contributor Author

Thanks @bryantjustin :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants