Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

Updates version to 3.4.0#307

Merged
rpassis merged 3 commits intorelease/3.4.0from
update-version
Apr 22, 2019
Merged

Updates version to 3.4.0#307
rpassis merged 3 commits intorelease/3.4.0from
update-version

Conversation

@jasonhawkins
Copy link
Copy Markdown
Contributor

Summary

Updates the VimeoNetworking pod and project file to version 3.4.0 in preparation for the next release.

@cameo-github
Copy link
Copy Markdown

6 Warnings
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L75: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L95: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIRefreshControl+AFNetworking.m#L104: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L76: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L97: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"
⚠️ Pods/AFNetworking/UIKit+AFNetworking/UIActivityIndicatorView+AFNetworking.m#L106: unknown warning group ‘-Wreceiver-is-weak’, ignored [-Wunknown-warning-option]
#pragma clang diagnostic ignored "-Wreceiver-is-weak"

See build details on CircleCI

Generated by 🚫 danger

@rpassis rpassis self-requested a review April 18, 2019 20:46
@rpassis
Copy link
Copy Markdown
Contributor

rpassis commented Apr 18, 2019

Hey this looks good but should the version bump happen on a release branch instead, and once released it gets merged into develop & master?

Also I am interested in going over the release process with you when this is ready to be pushed upstream and to CocoaPods.

@rpassis rpassis changed the base branch from develop to release/3.4.0 April 22, 2019 18:54
@rpassis rpassis merged commit 9e81ffa into release/3.4.0 Apr 22, 2019
@jasonhawkins jasonhawkins deleted the update-version branch May 2, 2019 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants