This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Merged
Conversation
rpassis
force-pushed
the
feature/VIM-6917_Swift42Migration
branch
from
d39c2f0 to
40c66c0
Compare
See build details on CircleCI Generated by 🚫 danger |
Jumhyn
approved these changes
Apr 24, 2019
Contributor
Jumhyn
left a comment
Jumhyn
left a comment
There was a problem hiding this comment.
One small question but otherwise LGTM
Contributor
jasonhawkins
left a comment
jasonhawkins
left a comment
There was a problem hiding this comment.
Just a couple of small comments on this 👍
rpassis
force-pushed
the
feature/VIM-6917_Swift42Migration
branch
2 times, most recently
from
749aa78 to
82ea2f7
Compare
rpassis
force-pushed
the
feature/VIM-6917_Swift42Migration
branch
from
82ea2f7 to
6f61862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
VIM-6917
Ticket Summary
Swift 4.2 migration
Implementation Summary
Changes include project settings update and necessary renames associated with Swift 4.2 migration.
It also fixes issue with the tvOS Example app that wasn't building due to source files not being correctly associated with the target.