This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Conversation
added 2 commits
December 2, 2016 12:02
Contributor
Author
Contributor
|
❤️ it! Is there an app PR? |
Contributor
Author
|
@alfiehanssen yeah cc'd ya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://vimean.atlassian.net/browse/VIM-4790
Ticket Summary
VimeoNetworking was previously using a different keychain configuration to store accounts than VIMNetworking. This PR reverts that change. This allows for seamless migrations from VIMNetworking to VimeoNetworking.
Implementation Summary
Modified the keychain keys. Also removed the default keychain values from AppConfiguration.
How to Test
Logged in, migrate from 6.1.3 to 6.1.4. You should remain logged in.