VIM-4977: JAM - Updated PR template proposal

[nicolelehrer]

Ticket

Required for Vimeans only
VIM-4977

Ticket Summary

Update PR template

Implementation Summary

Updated PR template with changes approved here: vimeo/VimeoNetworking#125

How to Test

N/A

[nicolelehrer]

Thanks @supperspidey!

[cameo-github]

	6 Warnings
⚠️	VimeoUpload/Upload/Descriptor System/Old Upload/OldUploadDescriptor.swift#L50: string interpolation produces a debug description for an optional value; did you mean to make this explicit? print("\(self.currentRequest.rawValue) \(self.identifier)")
⚠️	VimeoUpload/UIKit/DescriptorKVObserver.swift#L31: extraneous duplicate parameter name; ‘descriptorType’ already has an argument label func descriptorStateDidChange(descriptorType descriptorType: VideoDescriptorType, descriptorState: DescriptorState, isCancelled: Bool, descriptorError: NSError?)
⚠️	VimeoUpload/UIKit/DescriptorKVObserver.swift#L32: extraneous duplicate parameter name; ‘descriptorType’ already has an argument label func descriptorProgressDidChange(descriptorType descriptorType: VideoDescriptorType, progress: Double)
⚠️	VimeoUpload/Descriptor System/DescriptorManager.swift#L232: conditional downcast from ‘Error?’ to ‘NSError’ is a bridging conversion; did you mean to use ‘as’? let isConnectionError = ((task.error as? NSError)?.isConnectionError() == true || (error as? NSError)?.isConnectionError() == true)
⚠️	VimeoUpload/Upload/Extensions/AVAsset+Extensions.swift#L32: extraneous duplicate parameter name; ‘completion’ already has an argument label func approximateFileSize(completion completion: @escaping FloatBlock)
⚠️	VimeoUpload/Upload/Descriptor System/Cameo/CAMUploadDescriptor.swift#L27: string interpolation produces a debug description for an optional value; did you mean to make this explicit? print("\(self.currentRequest.rawValue) \(self.identifier)")

	2 Messages
📖	Executed 2 tests, with 0 failures (0 unexpected) in 0.308 (0.310) seconds
📖	Executed 2 tests, with 0 failures (0 unexpected) in 0.330 (0.334) seconds

See build details on CircleCI

Generated by 🚫 danger