Fix CI configuration and update Psalm for development #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d44c08.
staabm
reviewed
Mar 13, 2021
| - name: Validate composer.json and composer.lock | ||
| run: composer validate | ||
|
|
||
| - name: Cache Composer packages |
Contributor
There was a problem hiding this comment.
you should just use https://github.com/ramsey/composer-install - this would simplify your action and you don't need to work with this ugly github/action cache key things
Contributor
Author
There was a problem hiding this comment.
That point is correct, but adding dependency on non-official action requires trust in the action developer. Leave the decision to the administrator of this package.
Contributor
Author
|
The contents of composer.json were not reflected because the https://github.com/actions/cache/blob/main/examples.md#php---composer |
zonuexe
changed the title
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI for this project continues to fail since 144d67b, affecting #15 and #16.
These issues have been resolved in the latest version of Psalm, so updating the dependencies for this project will be successful.