Conversation
The `eq` method was unexported and as such was only used in tests. Given that we exposed other operator-like methods it was a bit of an anomaly in being unexported. To make it doubly weird, the default-generated `==` operator does exactly what one would expect for the concrete type, so there's *no* need for an `eq` method. Just rip it out and udpate the 3 tests that used it.
sachinagada
approved these changes
Dec 20, 2019
sergiosalvatore
approved these changes
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eqmethod was unexported and as such was only used in tests. Giventhat we exposed other operator-like methods it was a bit of an anomaly
in being unexported.
To make it doubly weird, the default-generated
==operator doesexactly what one would expect for the concrete type, so there's no
need for an
eqmethod. Just rip it out and udpate the 3 tests thatused it.
Fun fact: some of the call-sites required adding parenthesis because otherwise the Go parser gets upset when it sees a pair of braces and then sees the open-brace for the body of the if statement.