Skip to content

Add more impure functions to configuration#2053

Merged
muglug merged 2 commits intovimeo:masterfrom
iluuu1994:patch-1
Aug 23, 2019
Merged

Add more impure functions to configuration#2053
muglug merged 2 commits intovimeo:masterfrom
iluuu1994:patch-1

Conversation

@iluuu1994
Copy link
Copy Markdown
Contributor

Closes #2050

@iluuu1994
Copy link
Copy Markdown
Contributor Author

This list is very incomplete, it's just the ones I found in our codebase.

@iluuu1994
Copy link
Copy Markdown
Contributor Author

session_id and similar functions that act as getters and setters are unfortunate. If you call session_id() without parameters that will be a false negative after this PR...

@muglug muglug merged commit e0cd04d into vimeo:master Aug 23, 2019
@muglug
Copy link
Copy Markdown
Collaborator

muglug commented Aug 23, 2019

If you call session_id() without parameters that will be a false negative after this PR

I can live with that! Thanks!

@iluuu1994
Copy link
Copy Markdown
Contributor Author

Thanks @muglug 🙂

@iluuu1994 iluuu1994 deleted the patch-1 branch August 23, 2019 12:51
2e3s pushed a commit to 2e3s/psalm that referenced this pull request Sep 29, 2019
* Add more impure functions to configuration

Closes vimeo#2050

* Change note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call to session_name is unused

2 participants