Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

CI-487: publish stag artifacts and doc to MavenCentral#118

Merged
MathiasGr merged 1 commit intovimeo:masterfrom
MathiasGr:2.3.1release
Jun 27, 2017
Merged

CI-487: publish stag artifacts and doc to MavenCentral#118
MathiasGr merged 1 commit intovimeo:masterfrom
MathiasGr:2.3.1release

Conversation

@MathiasGr
Copy link
Copy Markdown
Contributor

Ticket

Required for Vimeans only
CI-487

Ticket Summary

publish stag artifacts and doc to MavenCentral

Implementation Summary

Based on the work done for vimeo-networking:

  • Fixed Javadoc errors
  • Updated Fastlane config
  • Updated build.gradle to add the proper pom.xml to stag-library and stag-library-compiler to conform to Metadata needed by Maven central and bintray.
  • Bumped version to 2.3.1

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #118   +/-   ##
=========================================
  Coverage     34.64%   34.64%           
  Complexity      167      167           
=========================================
  Files            89       89           
  Lines          2263     2263           
  Branches        343      343           
=========================================
  Hits            784      784           
  Misses         1359     1359           
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
...java/com/vimeo/stag/processor/utils/TypeUtils.java 61.9% <ø> (ø) 59 <0> (ø) ⬇️
...-library/src/main/java/com/vimeo/stag/UseStag.java 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4118871...f6f46c5. Read the comment docs.

Copy link
Copy Markdown
Contributor

@anthonycr anthonycr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one comment. Can you update the CHANGELOG.md file with information about the release and also update the README.md to point to 2.3.1 instead of 2.3.0?

Copy link
Copy Markdown
Contributor

@anthonycr anthonycr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MathiasGr MathiasGr merged commit 4bb93ae into vimeo:master Jun 27, 2017
@MathiasGr MathiasGr deleted the 2.3.1release branch June 27, 2017 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants