Indentation broken within lists

[ranebrown]

@tinmarino it looks like commit 21c5a7f broke the correct indentation within lists. It also disables the correct insertion of a new list character when pressing enter using :inoremap <silent><buffer> <CR> <C-]><Esc>:VimwikiReturn 3 5<CR>.

Expected:

- one two three four five six seven eight nine ten eleven twelve thirteen
  fourteen fifteen <-- press <CR> here should result in new marker
- 

Actual:

- one two three four five six seven eight nine ten eleven twelve thirteen
fourteen fifteen <-- <CR> here no new marker

Minimal vimrc:

set nocompatible
filetype plugin on
syntax on
set runtimepath+=~/vimwiki_dev

set textwidth=80
set linebreak
if has('patch-7.4.338')
  set breakindent
endif

augroup VimwikiKeyMap
    autocmd!
    autocmd FileType vimwiki inoremap <silent><buffer> <CR>
                \ <C-]><Esc>:VimwikiReturn 3 5<CR>
augroup END


let g:vimwiki_list = [
    \    {
    \      'path': '~/testwiki',
    \      'syntax': 'markdown',
    \      'ext': '.md',
    \    },]

[tinmarino]

Hi @ranebrown I cannot reproduce it. Isn't your second (not working) example missing of indentation ? What do you mean by "broke the correct indentation within lists" ?

- one two three four five six seven eight nine ten eleven twelve thirteen
  fourteen fifteen-->Cursor<--

Pressing Enter, do not gives a new marker but if :inoremap <silent><buffer> <CR> <C-]><Esc>:VimwikiReturn 3 5<CR>, I get

- one two three four five six seven eight nine ten eleven twelve thirteen
  fourteen fifteen
- -->Cursor<--

On my session: formatoptions=tqnj

When we fix that, I'd like to add tests.

[ranebrown]

With the hard line wrap at 80 characters the next line 'o' and 'f' should line up vertically as shown in the first example.

Isn't your second (not working) example missing of indentation

Yes, that is the first problem. The second problem being that the list marker - is not added.

This gif might help. The first part is the non working version and then I checkout an earlier commit.

[ranebrown]

I also updated the minimal vimrc so it includes the keymapping for VimwikiReturn

[tinmarino]

Ok I did no understand the hard wrap thing. It is, I guess, the only problem: the new marker is not added because the indentation got bad in the first place. I'll see that soon

[tinmarino]

Fixed: 817641e
The indentation gets fixed with the autoinsert comment setlocal formatoptions+=c which may have side effects.

I had trouble to get the new bullet at return, because vim kept adding lines with indent after the first one. Then I realized that this is what I wanted. You also get what you want with :inoremap <silent><buffer> <CR> <C-]><Esc>:VimwikiReturn 3 5<CR> and we keep the feature I was adding when I broke all is that bullet list can be joined removing the bullet prefix.

The same but more formally in tests list_return.vader

Now: formatoptions=tqclnj. Is that OK for you ?

[ranebrown]

Seems to be working now. Thanks for all the work you've been putting into Vimwiki.I haven't had the time with everything going on and I'm glad someone is still making improvements!

[tinmarino]

@ranebrown thanks for your encouragement. Glad to know I am on the good way. I, on the contrary, had a bit of time with everything going on.
Don't hesitate to open issue and assign them to me (anyway I can unassign if I don't feel): the github interface helps me to sort out the next issue I should track.
See you.