Skip to content

added flags.json and logger_config.yaml to container image.#20

Merged
sloppycoder merged 1 commit intomainfrom
18-flagsjson-not-packaged-into-container
May 9, 2025
Merged

added flags.json and logger_config.yaml to container image.#20
sloppycoder merged 1 commit intomainfrom
18-flagsjson-not-packaged-into-container

Conversation

@sloppycoder
Copy link
Contributor

check requirements when uv.lock is changed.
doc update

check requirements when uv.lock is changed.
doc update
@sloppycoder sloppycoder linked an issue May 9, 2025 that may be closed by this pull request
@sloppycoder sloppycoder requested a review from Copilot May 9, 2025 06:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configuration files to manage feature flags and logger settings and updates related tooling.

  • Updated the README.md to document the initialization of the feature flag provider.
  • Revised the pre-commit configuration to trigger requirements updates when either pyproject.toml or uv.lock changes.
  • Modified the .dockerignore file to explicitly include flags JSON files and logger configuration in the container image.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
{{cookiecutter.project_slug}}/README.md Updated documentation for settings.py to mention feature flag provider initialization.
{{cookiecutter.project_slug}}/.pre-commit-config.yaml Extended file matching to include uv.lock changes for requirement updates.
{{cookiecutter.project_slug}}/.dockerignore Added inclusion patterns for flags JSON files and logger_config.yaml to the container image.
Comments suppressed due to low confidence (1)

{{cookiecutter.project_slug}}/.dockerignore:11

  • [nitpick] Verify that the pattern '!flags*.json' accurately targets only the intended flag files and does not inadvertently include other JSON files that should remain excluded.
!flags*.json

| ------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [main.py](main.py) | main point for FastAPI |
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set |
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. |
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief note or a link to additional documentation explaining the feature flag provider configuration to help future maintainers.

Suggested change
| [settings.py](settings.py) | read settings from file specified by APP_SETTINGS_ENV or .env if it's not set. Also initializes feature flag provider. |
| [settings.py](settings.py) | Reads settings from a file specified by `APP_SETTINGS_ENV` or `.env` if it's not set. Also initializes the feature flag provider. For more details on configuring the feature flag provider, see [Feature Flag Provider Documentation](https://example.com/feature-flag-docs). |

Copilot uses AI. Check for mistakes.
@sloppycoder sloppycoder merged commit 34929e3 into main May 9, 2025
1 check passed
@sloppycoder sloppycoder deleted the 18-flagsjson-not-packaged-into-container branch May 9, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flags.json not packaged into container

2 participants