Merged
Conversation
Grillo-0
reviewed
Nov 13, 2024
Grillo-0
requested changes
Nov 14, 2024
Member
Grillo-0
left a comment
Grillo-0
left a comment
There was a problem hiding this comment.
Make the locale commit be the first one, because the other two doesn't work without it. And merge those two commits, (case-insensitive and Unicode support) as the Unicode is a fix for the case-insensitive one.
Member
|
Also, rebase the branch |
artP2
force-pushed
the
3-make-symbol-case-insensitive
branch
from
bb7fc58 to
d30ecd0
Compare
Grillo-0
requested changes
Dec 5, 2024
artP2
force-pushed
the
3-make-symbol-case-insensitive
branch
from
d30ecd0 to
5d4343b
Compare
Contributor
|
Build passing. |
Grillo-0
requested changes
Dec 7, 2024
Member
Grillo-0
left a comment
Grillo-0
left a comment
There was a problem hiding this comment.
All compiles and seems to work!
Just some nitpicks about the commit messages:
1# commit:
s/Added/Add
The commit message must be in the present tense, writing in a way that the commit modification will be added to the project, not as if it were already present in the project.
2# commit
The commit message body must be wrapped at 72 columns, to not be difficult to read when doing git log.
Add locale to support unicode character operations.
This change ensures that symbols are treated as case-insensitive as described in the language specification. All symbol texts are now converted to lowercase, including Unicode characters like 'Á' that were previously unsupported.
artP2
force-pushed
the
3-make-symbol-case-insensitive
branch
from
5d4343b to
fd20f12
Compare
Grillo-0
approved these changes
Dec 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the language description we say that symbols are case-insensitive, so this converts every symbol text to lowercase.
This is done by iterating through a SYMBOL node's text and using the C 'tolower' function.