Ensure collections of complex types marshall with no initialiser #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialiser we generate is largely only useful for nil values; specifically when we're building unmarshallers. It just so happens that it also works for marshalling builtin/ native types. For complex types, the method of passing a value to `new()` wont work; that isn't what `new()` does. Instead, though, because our `mint.MarshallerUnmarshallerValuer` expects a pointer receiver anyway, we can sub-out intialiser functions for an ampersand.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialiser we generate is largely only useful for nil values; specifically when we're building unmarshallers.
It just so happens that it also works for marshalling builtin/ native types.
For complex types, the method of passing a value to
new()wont work; that isn't whatnew()does.Instead, though, because our
mint.MarshallerUnmarshallerValuerexpects a pointer receiver anyway, we can sub-out intialiser functions for an ampersand.