Skip to content

Fix transfer not-found test expectations#110

Merged
JoshSEdwards merged 1 commit into
vinyldns:masterfrom
JoshSEdwards:fix/transfer-notfound-tests
May 28, 2026
Merged

Fix transfer not-found test expectations#110
JoshSEdwards merged 1 commit into
vinyldns:masterfrom
JoshSEdwards:fix/transfer-notfound-tests

Conversation

@JoshSEdwards
Copy link
Copy Markdown
Contributor

@JoshSEdwards JoshSEdwards commented May 27, 2026

Summary

  • align ownership transfer not-found tests with the client response contract
  • assert failure response details instead of expecting thrown exceptions
  • keep the fix limited to the new transfer coverage added in Add missing VinylDNS API endpoints #104

Why

The transfer methods fetch the record set first and return a failure response when that lookup returns a non-2xx status. The implementation does not throw on a 404, and that matches the rest of the client API behavior.

Testing

  • export JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
  • export PATH="$JAVA_HOME/bin:$PATH"
  • mvn -Dlicense.skip=true -Dfmt.skip=true -Dtest=VinylDNSClientTest test

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 27, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Member

@Sokitha-21 Sokitha-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JoshSEdwards JoshSEdwards merged commit 9df0174 into vinyldns:master May 28, 2026
3 checks passed
@JoshSEdwards JoshSEdwards deleted the fix/transfer-notfound-tests branch May 28, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants