Make xdgsurfaceitem and xwaylandsurfaceitem public#380
Merged
zccrs merged 1 commit intovioken:masterfrom Jun 18, 2024
Merged
Conversation
zccrs
requested changes
Jun 18, 2024
wineee
force-pushed
the
surfaceitem
branch
2 times, most recently
from
7046a28 to
795a875
Compare
zccrs
requested changes
Jun 18, 2024
zccrs
approved these changes
Jun 18, 2024
wineee
commented
Jun 18, 2024
| QRectF getContentGeometry() const override; | ||
| QSizeF getContentSize() const override; | ||
| void geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry) override; | ||
| Q_SLOT void updatePosition(); |
Member
Author
There was a problem hiding this comment.
Should this slot move to WXWaylandSurfaceItemPrivate？
wineee
commented
Jun 18, 2024
| // TODO: Maybe we shouldn't think about the effectiveVisible for surface/item's position | ||
| // This behovior can control by compositor using PositionMode::ManualPosition | ||
| connect(this, &WXWaylandSurfaceItem::effectiveVisibleChanged, | ||
| this, &WXWaylandSurfaceItem::updatePosition, Qt::UniqueConnection); |
Member
Author
There was a problem hiding this comment.
Not Sure if UniqueConnection works for lambda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.