Texture#478
Merged
zccrs merged 2 commits intovioken:masterfrom Sep 3, 2024
Merged
Conversation
zccrs
force-pushed
the
texture
branch
5 times, most recently
from
3e90c30 to
2dde7e3
Compare
wineee
approved these changes
Sep 2, 2024
Renamed WBufferTextureProvider to WSGTextureProvider. Deprecated and removed WTexture, moving its core implementation to WRenderHelper. The logic for handling qw_buffer objects has been transferred to WBufferTextureProvider. Most of the WSGTextureProvider implementations are similar, so the texture providers from multiple objects have been consolidated into WSGTextureProvider to avoid redundant code. Additionally, the implementation of WSGTextureProvider has been refactored to reuse a single QSGPlainTexture object, rather than destroying and recreating it with qw_texture as was done previously. Refactored the usage of QSGTextureProvider in WSurfaceItem and other objects to adapt to WSGTextureProvider, ensuring they are only used on the render thread as specified in the Qt documentation. Changes made to WSurfaceItem::updatePaintNode during the refactoring resolved a potential crash issue. Previously, when updating the paint node, calling markDirty(DirtyMaterial) alone was incorrect because the QSGTexture object might have changed. Now, always calling setTexture ensures this issue is addressed.
The way WQuickTextureProxy was using QSGTextureProvider was incorrect. According to the Qt documentation, the QQuickItem::textureProvider function should only be called from the render thread.
asterwyx
reviewed
Sep 2, 2024
Groveer
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.