Fix xwayland#525
Merged
zccrs merged 2 commits intovioken:masterfrom Oct 30, 2024
Merged
Conversation
wineee
force-pushed
the
fix-xwayland
branch
3 times, most recently
from
e5ca780 to
6387eed
Compare
zccrs
requested changes
Oct 30, 2024
|
|
||
| // xwaylandSurface->requestConfigureFlags().testAnyFlags(WXWaylandSurface::ConfigureFlag::XCB_CONFIG_WINDOW_POSITION) | ||
| auto requestPos = xwaylandSurface->requestConfigureGeometry().topLeft(); | ||
| if (!requestPos.isNull()) { // howto check WINDOW_POSITION never configured? |
Member
Author
There was a problem hiding this comment.
requestConfigureFlags will be override if config twice
wineee
force-pushed
the
fix-xwayland
branch
2 times, most recently
from
b969915 to
2ab83ea
Compare
zccrs
requested changes
Oct 30, 2024
|
|
||
| // xwaylandSurface->requestConfigureFlags().testAnyFlags(WXWaylandSurface::ConfigureFlag::XCB_CONFIG_WINDOW_POSITION) | ||
| auto requestPos = xwaylandSurface->requestConfigureGeometry().topLeft(); | ||
| if (!requestPos.isNull()) { // howto check WINDOW_POSITION never configured? |
zccrs
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.