Fix popup crash when parent is layer surface#550
Merged
zccrs merged 1 commit intovioken:masterfrom Nov 22, 2024
Merged
Conversation
wineee
force-pushed
the
fix-a
branch
3 times, most recently
from
d268f38 to
6750e39
Compare
zccrs
requested changes
Nov 22, 2024
| void surfaceAdded(WLayerSurface *surface); | ||
| void surfaceRemoved(WLayerSurface *surface); | ||
|
|
||
| void newXdgPopupSurface(wlr_xdg_popup *popup); |
Contributor
There was a problem hiding this comment.
xdgPopupSurfaceAdded(WXdgPopupSurface)
When layer_surface is an xdg_popup's parent, the popup should created via xdg_surface::get_popup with the parent set to NULL, and 'zwlr_layer_surface_v1::get_popup' must be invoked before committing the popup's initial state. We should use parent's `notify_new_popup` to avoid get a popup with NULL parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When layer_surface is an xdg_popup's parent, the popup should created via xdg_surface::get_popup with the parent set to NULL, and 'zwlr_layer_surface_v1::get_popup' must be invoked before committing the popup's initial state.
We should use parent's
notify_new_popupto avoid get a popup with NULLparent