fix: texture invalid in non-live state#560
Merged
zccrs merged 1 commit intovioken:masterfrom Nov 29, 2024
Merged
Conversation
zccrs
requested changes
Nov 28, 2024
asterwyx
force-pushed
the
live-buffer
branch
from
8e95814 to
83be909
Compare
zccrs
requested changes
Nov 29, 2024
Buffer update is not controlled by live property. Previous buffer is not refered, thus might be destroyed. Pends new buffer in non-live state.
asterwyx
force-pushed
the
live-buffer
branch
from
83be909 to
14fdc7b
Compare
zccrs
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer update is not controlled by live property. Previous buffer is not refered, thus might be destroyed. Pends new buffer in non-live state.