[SOL66-7] Ensure proper _afterFallback hook call#9
Merged
0xpApaSmURf merged 1 commit intodevfrom Jun 22, 2022
Merged
Conversation
…, also removed redundant boolean checks
ra-phael
reviewed
Jun 21, 2022
Contributor
ra-phael
left a comment
ra-phael
left a comment
There was a problem hiding this comment.
Let's add some tests to make sure we "lock" the intended behavior? Tests that would have failed before the fix.
Contributor
Author
|
So the behaviour doesn't change actually. There was no material behaviour change, the code just looked weird and was attempting to handle the case in a suboptimal/ less readable way. |
ra-phael
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.