Fix pretty printer for termination measures#831
Merged
Conversation
2 tasks
marcoeilers
approved these changes
Jan 10, 2025
Contributor
marcoeilers
left a comment
There was a problem hiding this comment.
LGTM. It doesn't look great if the standard silver code refers to a plugin, but IIRC we decided that the termination plugin is supposed to be considered an actual part of silver now, so I think that's fine.
Contributor
Author
|
I was equally apprehensive to make the silver code dependent on a plugin, but having termination checks implemented by a plugin has been a fruitful source of bugs and hacks. I think termination should always have been a part of the language, and I am glad to move in that direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While pretty printing the Viper files emitted by Gobra, I found two issues with the pretty printer of termination measures:
requires decreases Xinstead ofdecreases XFor a concrete example, viper pretty prints
instead of
PS: I don't understand why predicate instances where being printed with a "@" in the first place, and as far as I can tell, no one relies on this behaviour. Maybe @mschwerhoff knows why.