Skip to content

Recursively traverse let expressions when inferring triggers, not just once#890

Merged
marcoeilers merged 3 commits intomasterfrom
meilers_fix_silver_943
Oct 10, 2025
Merged

Recursively traverse let expressions when inferring triggers, not just once#890
marcoeilers merged 3 commits intomasterfrom
meilers_fix_silver_943

Conversation

@marcoeilers
Copy link
Copy Markdown
Contributor

Fixes Silicon issue viperproject/silicon#943.

@Aurel300
Copy link
Copy Markdown
Member

Aurel300 commented Oct 8, 2025

Should we contribute a minimised test case? Is the verification for this acceptable?

@marcoeilers
Copy link
Copy Markdown
Contributor Author

The verification time for the test case is under two seconds in both backends.
But yes, if you can come up with a minimised test case for this, I'd be very happy to add that. It's not super trivial though; I can easily write an example where Viper can now find a trigger but couldn't before, but it's not as easy to write an example where Z3 then doesn't just infer the trigger itself.

@marcoeilers marcoeilers merged commit 45204c9 into master Oct 10, 2025
5 checks passed
@marcoeilers marcoeilers deleted the meilers_fix_silver_943 branch October 10, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants