Skip to content

Add command to tweak threshold on the fly#121

Merged
Robin5605 merged 3 commits intomainfrom
tweak-score
Jul 11, 2023
Merged

Add command to tweak threshold on the fly#121
Robin5605 merged 3 commits intomainfrom
tweak-score

Conversation

@Robin5605
Copy link
Member

Closes #116

Copy link
Member

@import-pandas-as-numpy import-pandas-as-numpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't persist state, right?
We'll have to remember to set this to the desired value from the default whenever the bot is restarted.

That doesn't sound ideal.

@Robin5605
Copy link
Member Author

This doesn't persist state, right?
We'll have to remember to set this to the desired value from the default whenever the bot is restarted.

That doesn't sound ideal.

It doesn't, but I intend for this to mostly be a debugging tool to see if packages are being flagged at all, a more permanent solution would have to be implemented on the API's side where there is a database to persist that information to. I'll make an issue there where we can discuss how to build that feature out. But for now I think this should suffice.

Copy link
Contributor

@sid-maddy sid-maddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@import-pandas-as-numpy
Copy link
Member

This doesn't persist state, right?
We'll have to remember to set this to the desired value from the default whenever the bot is restarted.
That doesn't sound ideal.

It doesn't, but I intend for this to mostly be a debugging tool to see if packages are being flagged at all, a more permanent solution would have to be implemented on the API's side where there is a database to persist that information to. I'll make an issue there where we can discuss how to build that feature out. But for now I think this should suffice.

LGTM. :shipit:

@Robin5605 Robin5605 merged commit de919bc into main Jul 11, 2023
@Robin5605 Robin5605 deleted the tweak-score branch July 11, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tweak score threshold on the fly

3 participants