Fix report payload to not always override#129
Merged
shenanigansd merged 1 commit intomainfrom Jul 18, 2023
Merged
Conversation
sid-maddy
approved these changes
Jul 18, 2023
Comment on lines
+43
to
+44
| additional_information_override = self.additional_information or None | ||
| inspector_url_override = self.inspector_url or None |
Contributor
There was a problem hiding this comment.
nit: remove the _override suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The popup modal is intended to be an "override" setting to override what's in the database. The Mainframe API would use the "override" if it's not None. However,
discord.pyreturns""forui.TextInputs that were not filled out, which is not None. This meant that the empty string would always override what's in the database when sending the email report, which is undesirable.This PR fixes it so that
""becomesNone, which is then sent as the HTTP payload.