Conversation
import-pandas-as-numpy
approved these changes
Jul 22, 2023
Member
import-pandas-as-numpy
left a comment
import-pandas-as-numpy
left a comment
There was a problem hiding this comment.
LGTM. before_loop required some googling to make sure you weren't making up random crap.
sid-maddy
reviewed
Jul 22, 2023
| async def setup(bot: Bot) -> None: | ||
| await bot.add_cog(Dragonfly(bot)) | ||
| cog = Dragonfly(bot) | ||
| cog.scan_loop.start() |
Contributor
There was a problem hiding this comment.
Will this cause a RuntimeError if the extension is reloaded?
Move the scan loop task's startup code into the cog's `setup()` method because it makes more sense to do it there and also simultaneously avoids circular imports. Also avoids cluttering the "global" `setup_hook` of the bot with any other auto-start tasks we might need in the future.
Signed-off-by: Robin <74519799+Robin5605@users.noreply.github.com>
Robin5605
force-pushed
the
task-on-startup
branch
from
f69c022 to
0438188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
Starts the Dragonfly task in charge of posting scan results on bot startup