Skip to content

Add error handling to task#192

Merged
Robin5605 merged 3 commits intomainfrom
error-handling
Nov 11, 2023
Merged

Add error handling to task#192
Robin5605 merged 3 commits intomainfrom
error-handling

Conversation

@Robin5605
Copy link
Member

@Robin5605 Robin5605 commented Nov 8, 2023

Closes #145 and #186
This should hopefully quell the common TypeError: string indices must be integers, not 'str' error we keep getting. The root
error of this lies in Mainframe, but the bot should now skip the current loop iteration if it errors out, and try it again next time. A Sentry event will be created for observability.

@Robin5605 Robin5605 enabled auto-merge November 8, 2023 01:58
Copy link
Member

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM.

@Robin5605
Copy link
Member Author

#195 needs to be merged first for CI to pass

@Robin5605 Robin5605 merged commit 08e6eee into main Nov 11, 2023
@Robin5605 Robin5605 deleted the error-handling branch November 11, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle errors in task

2 participants