Skip to content

Make package reported logs an embed#206

Merged
Robin5605 merged 1 commit intomainfrom
robin/feat/reporting-embed
Feb 3, 2024
Merged

Make package reported logs an embed#206
Robin5605 merged 1 commit intomainfrom
robin/feat/reporting-embed

Conversation

@Robin5605
Copy link
Member

Closes #205

Here's how the embed looks:
image

The Inspector URL link is whatever the user provided in the modal, or if they didn't provide one, it falls back to whatever was scanned by the client.
Likewise, the description falls back to "No description provided" if one was not provided in the modal.

Copy link
Member

@import-pandas-as-numpy import-pandas-as-numpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Robin5605 Robin5605 merged commit 883c126 into main Feb 3, 2024
@Robin5605 Robin5605 deleted the robin/feat/reporting-embed branch February 3, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use embeds in #reporting

2 participants