fix(virtio-net): waiting infinetely for bridge to be created#47
Merged
mfernd merged 5 commits intovirt-do:mainfrom May 6, 2024
mfernd:fix/virtio-net
Merged
fix(virtio-net): waiting infinetely for bridge to be created#47mfernd merged 5 commits intovirt-do:mainfrom mfernd:fix/virtio-net
mfernd merged 5 commits intovirt-do:mainfrom
mfernd:fix/virtio-net
Conversation
added 2 commits
May 6, 2024 01:42
remove futures block_on in bridge module, because they're not polled (so not executed) Signed-off-by: Mateo Fernandez <mateo.fernandez@etu.umontpellier.fr>
Signed-off-by: Mateo Fernandez <mateo.fernandez@etu.umontpellier.fr>
added 3 commits
May 6, 2024 04:17
Signed-off-by: Mateo Fernandez <mateo.fernandez@etu.umontpellier.fr>
Signed-off-by: Mateo Fernandez <mateo.fernandez@etu.umontpellier.fr>
Signed-off-by: Mateo Fernandez <mateo.fernandez@etu.umontpellier.fr>
mfernd
requested review from
a team
and removed request for
Kuruyia and
sylvain-pierrot
Kuruyia
approved these changes
May 6, 2024
Contributor
Kuruyia
left a comment
Kuruyia
left a comment
There was a problem hiding this comment.
Thanks for the fix and cleaning this up :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As I've seen with @sylvain-pierrot and @thomas-mauran, the problem comes from
vmm::core::devices::virtio::net::bridge#L26where thefutures::executor::block_on(so everywhere there is this in this module). The future seems to never be polled by the executor, so fromtokioorfutures.To solve the problem, I removed all of these (
block_on), updated the function signatures withasyncin bridge.rs and propagated it up to the VMM.(I also refactored the code in
bridge.rsto be a bit more readable.)Expected behavior
Before:
The VMM orchestrator wait infinitely at the Net configuration step:
After:
Now it works correctly, and I've added a bit of logging to see the step in the network part:
