Conversation
luniki
reviewed
Jun 18, 2021
| if(isset($courseware_settings['reminder_interval'])){ | ||
| $this->storeReminderInterval($courseware_settings['reminder_interval']); | ||
| } else { | ||
| $this->storeReminderInterval('5'); // default jährlich |
Member
There was a problem hiding this comment.
Hier bitte Konstanten verwenden, das macht es lesbarer.
| if(isset($courseware_settings['resetter_interval'])){ | ||
| $this->storeResetterInterval($courseware_settings['resetter_interval']); | ||
| } else { | ||
| $this->storeResetterInterval('5'); // default jährlich |
| return $this->redirect('progress?cid='.$cid); | ||
| } | ||
|
|
||
| require_once dirname(__FILE__).'/../pdf/coursewareCertificatePDF.php'; |
Member
There was a problem hiding this comment.
Warum lädst du diese Klasse selbst? Warum nicht über den Autoloader?
| $pdf->writeHTML($html, true, false, true, false, ''); | ||
| $filename = _('Zertifikat'); | ||
| $pdf->Output($user->nachname.'_'.$course->name.'_'.$filename.'.pdf', 'I'); | ||
| die; |
Member
There was a problem hiding this comment.
Müsste doch mit $this->render_nothing() auch funktionieren?
| } | ||
| $is_in_interval = false; | ||
| switch ($interval) { | ||
| case '0': //wöchentlich |
|
|
||
| public function getReminderStartDate() | ||
| { | ||
| return $this->reminder_start_date == '' ? '': date('d.m.Y', (int) $this->reminder_start_date); |
Member
There was a problem hiding this comment.
Hier muss das Format von reminder_start_date festgelegt sein.
Mein Vorschlag: Entweder ein String im Format d.m.Y oder null.
luniki
reviewed
Jun 18, 2021
|
|
||
| public function setReminderStartDate($state) | ||
| { | ||
| $this->reminder_start_date = $state; |
Member
There was a problem hiding this comment.
Hier wäre gut, wenn die Eingabe geprüft würde. Erlaubte Werte sind analog dann ein String im Format d.m.Y oder null.
luniki
reviewed
Jun 18, 2021
| return $this->reminder_start_date == '' ? '': date('d.m.Y', (int) $this->reminder_start_date); | ||
| } | ||
|
|
||
| public function setReminderEndDate($state) |
Member
There was a problem hiding this comment.
Hier dasselbe wie für reminder start
luniki
reviewed
Jun 18, 2021
| $this->reminder_end_date = $state; | ||
| } | ||
|
|
||
| public function getReminderEndDate() |
luniki
reviewed
Jun 18, 2021
| return $this->reseter; | ||
| } | ||
|
|
||
| public function setReseterInterval($state) |
luniki
approved these changes
Jun 24, 2021
| return $this->reseter_interval; | ||
| } | ||
|
|
||
| public function setReseterStartDate($state) |
| return $this->reseter_start_date = $state; | ||
| } | ||
|
|
||
| public function getReseterStartDate() |
| return $this->reminder; | ||
| } | ||
|
|
||
| public function setReminderInterval($state) |
Member
There was a problem hiding this comment.
Eingabe prüfen, ob sie zu den Konstanten gehört.
| return $this->resetter; | ||
| } | ||
|
|
||
| public function setResetterInterval($state) |
| //////////////////////// | ||
| // Certificate // | ||
| //////////////////////// | ||
| if ($courseware_settings['certificate'] === '1') { |
Member
|
Spricht nichts gegen einen Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.