feat: remove iimi analysis viewer and workflow option#1086
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider typing
supportedWorkflowsasAnalysisWorkflow[]socheckSupportedWorkflowstays in sync with the union type and future workflow additions or removals are caught by the compiler. - In
Viewer/Sort.tsx, you could type thesortKeys/sortTitlesobjects usingAnalysisWorkflowfor their top-level keys to avoid them drifting from the supported workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider typing `supportedWorkflows` as `AnalysisWorkflow[]` so `checkSupportedWorkflow` stays in sync with the union type and future workflow additions or removals are caught by the compiler.
- In `Viewer/Sort.tsx`, you could type the `sortKeys`/`sortTitles` objects using `AnalysisWorkflow` for their top-level keys to avoid them drifting from the supported workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Addressed in cf4512b:
Not applying `AnalysisWorkflow` to `sortTitles` — its keys are sort-field names (coverage, depth, e, …), not workflows, so the union does not apply there. |
Summary
Iimi/components and its iimi-only charts), iimi types, formatting utilities, fixtures, and the iimi sort options.iimifrom the workflow enums and display-name maps (jobs/types.ts,app/utils.ts,AnalysisWorkflow), so it no longer appears as a supported workflow.iimiis clean; typecheck, lint, and the analyses/jobs test suites pass.