Skip to content

feat: remove iimi analysis viewer and workflow option#1086

Merged
igboyes merged 2 commits into
mainfrom
igboyes/vir-2551-strip-all-remaining-iimi-and-ml-support-from-the-frontend
Jun 30, 2026
Merged

feat: remove iimi analysis viewer and workflow option#1086
igboyes merged 2 commits into
mainfrom
igboyes/vir-2551-strip-all-remaining-iimi-and-ml-support-from-the-frontend

Conversation

@igboyes

@igboyes igboyes commented Jun 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes the remaining iimi frontend code now that the backend no longer returns iimi analyses: the analysis results viewer (Iimi/ components and its iimi-only charts), iimi types, formatting utilities, fixtures, and the iimi sort options.
  • Drops iimi from the workflow enums and display-name maps (jobs/types.ts, app/utils.ts, AnalysisWorkflow), so it no longer appears as a supported workflow.
  • Completes VIR-2551, following the earlier removal of iimi creation and ML model support (VIR-2548). Grep for iimi is clean; typecheck, lint, and the analyses/jobs test suites pass.

@linear-code

linear-code Bot commented Jun 29, 2026

Copy link
Copy Markdown

VIR-2551

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@igboyes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5d7ae2f3-af34-4ff3-8de1-77e6d4f2cee1

📥 Commits

Reviewing files that changed from the base of the PR and between 74b7cb3 and cf4512b.

📒 Files selected for processing (16)
  • apps/web/src/analyses/components/AnalysisDetail.tsx
  • apps/web/src/analyses/components/Charts/CoverageChart.tsx
  • apps/web/src/analyses/components/Charts/SummaryChart.tsx
  • apps/web/src/analyses/components/Iimi/IimiCondensedCoverage.tsx
  • apps/web/src/analyses/components/Iimi/IimiDetection.tsx
  • apps/web/src/analyses/components/Iimi/IimiIsolate.tsx
  • apps/web/src/analyses/components/Iimi/IimiOtu.tsx
  • apps/web/src/analyses/components/Iimi/IimiToolbar.tsx
  • apps/web/src/analyses/components/Iimi/IimiViewer.tsx
  • apps/web/src/analyses/components/Iimi/__tests__/IimiViewer.test.tsx
  • apps/web/src/analyses/components/Viewer/Sort.tsx
  • apps/web/src/analyses/types.ts
  • apps/web/src/analyses/utils.ts
  • apps/web/src/app/utils.ts
  • apps/web/src/jobs/types.ts
  • apps/web/src/tests/fake/analyses.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider typing supportedWorkflows as AnalysisWorkflow[] so checkSupportedWorkflow stays in sync with the union type and future workflow additions or removals are caught by the compiler.
  • In Viewer/Sort.tsx, you could type the sortKeys/sortTitles objects using AnalysisWorkflow for their top-level keys to avoid them drifting from the supported workflows.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider typing `supportedWorkflows` as `AnalysisWorkflow[]` so `checkSupportedWorkflow` stays in sync with the union type and future workflow additions or removals are caught by the compiler.
- In `Viewer/Sort.tsx`, you could type the `sortKeys`/`sortTitles` objects using `AnalysisWorkflow` for their top-level keys to avoid them drifting from the supported workflows.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@igboyes

igboyes commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Addressed in cf4512b:

  • `supportedWorkflows` is now typed `AnalysisWorkflow[]` in `analyses/utils.ts`.
  • `sortKeys` in `Viewer/Sort.tsx` is now `Record<AnalysisWorkflow, string[]>`, and the `workflow` prop is typed `AnalysisWorkflow` so the lookup stays in sync.

Not applying `AnalysisWorkflow` to `sortTitles` — its keys are sort-field names (coverage, depth, e, …), not workflows, so the union does not apply there.

@igboyes igboyes merged commit cdd2d1a into main Jun 30, 2026
11 checks passed
@igboyes igboyes deleted the igboyes/vir-2551-strip-all-remaining-iimi-and-ml-support-from-the-frontend branch June 30, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant