Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Clone the ResourceManager type from virtual-kubelet#2

Merged
cpuguy83 merged 1 commit intovirtual-kubelet:masterfrom
gabrielhartmann:rm
Aug 2, 2019
Merged

Clone the ResourceManager type from virtual-kubelet#2
cpuguy83 merged 1 commit intovirtual-kubelet:masterfrom
gabrielhartmann:rm

Conversation

@gabrielhartmann
Copy link
Copy Markdown
Contributor

@gabrielhartmann gabrielhartmann commented Jul 22, 2019

This change allows migration to the v1.0 release of virtual-kubelet. Resolves issue #1
Closes #1

This change allows migration to the v1.0 release of virtual-kubelet
Copy link
Copy Markdown
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cpuguy83
Copy link
Copy Markdown
Collaborator

cpuguy83 commented Jul 22, 2019

@lucperkins

What's the process for setting up the CLA checker on this repo?

@gabrielhartmann
Copy link
Copy Markdown
Contributor Author

@cpuguy83: Anyone else's review needed before merge?

@cpuguy83
Copy link
Copy Markdown
Collaborator

I just want to get the CLA checker in and we can merge, sorry for the wait!

@gabrielhartmann
Copy link
Copy Markdown
Contributor Author

No worries.

@gabrielhartmann
Copy link
Copy Markdown
Contributor Author

@cpuguy83 : Any news here?

@cpuguy83
Copy link
Copy Markdown
Collaborator

/cc @rbitia You mentioned you knew how to get the CLA bot going?

@cpuguy83
Copy link
Copy Markdown
Collaborator

cpuguy83 commented Aug 2, 2019

Yay, looks like it's added.

Copy link
Copy Markdown
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 2635841 into virtual-kubelet:master Aug 2, 2019
@cpuguy83
Copy link
Copy Markdown
Collaborator

cpuguy83 commented Aug 2, 2019

@gabrielhartmann Thanks for your patience!

@gabrielhartmann
Copy link
Copy Markdown
Contributor Author

Thanks @cpuguy83

@gabrielhartmann gabrielhartmann deleted the rm branch August 2, 2019 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to import Resource Manager from virtual-kubelet 1.0

2 participants