Fix field data algorithim#1477
Merged
Ezequiel-Valencia merged 21 commits intomasterfrom Apr 16, 2025
Merged
Conversation
Simplify the field data algorithm. Removing recursion, unnecessary variables, creating new functions, and condensing expressions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Throw an error if the file given will produce field data of extremely large dimensions.
Throw unsupported exceptions, rename classes and variables, and regenerate clients.
jcschaff
approved these changes
Apr 16, 2025
Member
jcschaff
left a comment
jcschaff
left a comment
There was a problem hiding this comment.
discussion with @Ezequiel-Valencia, comments incorporated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field data algorithm, which analyzes a file and writes down each channel's pixel data based on its content, has now been moved from client-side execution to server-side execution. This transition also features improvements in memory management.